support Jackson v3 #837
support Jackson v3 #837
Conversation
docs javafmt jackson2 in docs Update build.sbt fix tests by using jackson 2 style config Update json-support.md Update json-support.md test fix Update json-support.md Update Jackson.java Update json-support.md revert format change
| } | ||
|
|
||
| private static ObjectMapper createMapper() { | ||
| return createMapper(ConfigFactory.load().getConfig("pekko.http.marshallers.jackson3")); |
There was a problem hiding this comment.
is it possible to make it overrideable?
There was a problem hiding this comment.
The API methods allow you to provide your own ObjectMapper so this code is just for the case where we need to create an ObjectMapper instance because the user hasn't provided one.
If we were to open this up, I would prefer if users were requesting it. This is a copy of the code from pekko-http-jackson and noone was requesting any changes to this for that module.
| + maxTokenCount | ||
| + "\n" | ||
| + "read.max-nesting-depth=" | ||
| + maxNestingDepth; |
There was a problem hiding this comment.
The aim is to backport this PR to v1.3.0 so I need code that compiles with Java 8.
There was a problem hiding this comment.
You can use the Java 17 version for this PR and then modify the cherry pick for 1.3.0 with git rebase, but it might be simpler to just stick with Java 8 syntax
docs javafmt jackson2 in docs Update build.sbt fix tests by using jackson 2 style config Update json-support.md Update json-support.md test fix Update json-support.md Update Jackson.java Update json-support.md revert format change
3 participants
Idea is to leave pekko-http-jackson as supporting Jackson v2.x and to add a pekko-http-jackson3.
Jackson 3 is a significant rewrite and has lots of config changes compared to Jackson 2.
Aim is to backport this to 1.3.x branch to include in the 1.3.0 release.